Skip to content

Conversation

@kradalby
Copy link
Collaborator

Fixes #2584
Fixes #2474

@kradalby kradalby requested a review from juanfont as a code owner May 14, 2025 12:48
@ghost
Copy link

ghost commented May 14, 2025

Pull Request Revisions

RevisionDescription
r2
Enhanced OIDC identifier generation and cleaningImproved Identifier() and CleanIdentifier() methods for better handling of whitespace, URL schemes, and path segments
r1
Improved OIDC identifier handling logicAdded robust identifier cleaning and generation methods for OIDC claims, including handling URLs, double slashes, and edge cases in provider identifiers

✅ AI review completed for r2
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kradalby kradalby force-pushed the kradalby/double-slash-oidc branch from fe39e7e to 3f4c357 Compare May 14, 2025 13:48
@kradalby kradalby merged commit 2dc2f3b into juanfont:main May 14, 2025
142 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PR #2474 can cause duplicate users

2 participants