Skip to content

Conversation

@kradalby
Copy link
Collaborator

Updates #2333

Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby force-pushed the kradalby/casbin-user branch from 21ac038 to e033a7a Compare April 16, 2025 12:22
@ghost
Copy link

ghost commented Apr 16, 2025

Pull Request Revisions

RevisionDescription
r3
Improved OIDC claims identifier generationAdded URL path joining for OIDC claims identifier when issuer starts with "http", with fallback to previous method
r2
Removed extra slash in URLFixed OIDC provider identifier URL by removing an extra forward slash in the test case configuration
r1
Added OIDC claims test caseExpanded users_test.go with a new test case for OIDC claims parsing, covering a specific GitHub issue scenario

✅ AI review completed for r3
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

DisplayName: "User001",
Email: "[email protected]",
ProviderIdentifier: sql.NullString{
String: "https://oidc.example.com//xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a double slash in the ProviderIdentifier URL string: https://oidc.example.com//xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. Is this intentional or should it be a single slash after the domain?

@kradalby kradalby merged commit 098ab03 into juanfont:main Apr 23, 2025
270 of 276 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants