Skip to content

Conversation

@gnpaone
Copy link

@gnpaone gnpaone commented May 11, 2025

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #2584

@ghost
Copy link

ghost commented May 11, 2025

Pull Request Revisions

RevisionDescription
r1
Improved OIDC claims identifier generationUpdated Identifier() method to robustly handle URL trimming and joining for OIDC claims

☑️ AI review skipped for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kradalby
Copy link
Collaborator

Addressed in #2593

@kradalby kradalby closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PR #2474 can cause duplicate users

2 participants