Skip to content

[hotfix][javadoc] Use skip-webui-build while javadoc:aggregate #27401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snuyanzin wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

[hotfix][javadoc] Use skip-webui-build while javadoc:aggregate #27401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/ci/compile.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ javadoc_output=/tmp/javadoc.out
# use the same invocation as .github/workflows/docs.sh
$MVN javadoc:aggregate -DadditionalJOption='-Xdoclint:none' \
-Dmaven.javadoc.failOnError=false -Dcheckstyle.skip=true -Denforcer.skip=true -Dspotless.skip=true -Drat.skip=true \
-Dheader=someTestHeader > ${javadoc_output}
-Dheader=someTestHeader -Pskip-webui-build > ${javadoc_output}
Copy link
Contributor Author

@snuyanzin snuyanzin Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something wrong is happening with azure

compile takes more than 2 hours for the recent master build https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=71583&view=results

at the same time with this change it takes only one hour https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=71589&view=logs&s=ae4f8708-9994-57d3-c2d7-b892156e7812&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5

At the same time I still tend to think that the problem is somewhere on azure or Alibaba (we use their server there) side, since there is no noticeable change in GHA

Copy link
Contributor

@davidradl davidradl Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to skip the tests short term. Is there a Jira to track this issue and maybe include the Jira number in a comment here.

Copy link
Contributor Author

@snuyanzin snuyanzin Jan 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think it is short term, there is no javadocs in web ui build, so anyway it doesn't make sense to include it while building javadoc

in case of hotfix it doesn't make sense to create a jira imho

Copy link
Contributor

@davidradl davidradl Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that makes sense- thanks for the extra detail.

EXIT_CODE=$?
if [ $EXIT_CODE != 0 ] ; then
echo "ERROR in Javadocs. Printing full output:"
Expand Down