[hotfix][javadoc] Use skip-webui-build while javadoc:aggregate
#27401
Conversation
skip-webui-build while javadoc:aggregateskip-webui-build while javadoc:aggregate
| $MVN javadoc:aggregate -DadditionalJOption='-Xdoclint:none' \ | ||
| -Dmaven.javadoc.failOnError=false -Dcheckstyle.skip=true -Denforcer.skip=true -Dspotless.skip=true -Drat.skip=true \ | ||
| -Dheader=someTestHeader > ${javadoc_output} | ||
| -Dheader=someTestHeader -Pskip-webui-build > ${javadoc_output} |
There was a problem hiding this comment.
Something wrong is happening with azure
compile takes more than 2 hours for the recent master build https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=71583&view=results
at the same time with this change it takes only one hour https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=71589&view=logs&s=ae4f8708-9994-57d3-c2d7-b892156e7812&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5
At the same time I still tend to think that the problem is somewhere on azure or Alibaba (we use their server there) side, since there is no noticeable change in GHA
There was a problem hiding this comment.
Makes sense to skip the tests short term. Is there a Jira to track this issue and maybe include the Jira number in a comment here.
There was a problem hiding this comment.
don't think it is short term, there is no javadocs in web ui build, so anyway it doesn't make sense to include it while building javadoc
in case of hotfix it doesn't make sense to create a jira imho
There was a problem hiding this comment.
ok that makes sense- thanks for the extra detail.
What is the purpose of the change
The hotfix commit which skips web ui build while
javadoc:aggregatetaskAfter that this task for me locally takes about 20 sec instead of 1.5 min
Brief change log
compile.shVerifying this change
existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation