Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something wrong is happening with azure
compile takes more than 2 hours for the recent master build https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=71583&view=results
at the same time with this change it takes only one hour https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=71589&view=logs&s=ae4f8708-9994-57d3-c2d7-b892156e7812&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5
At the same time I still tend to think that the problem is somewhere on azure or Alibaba (we use their server there) side, since there is no noticeable change in GHA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to skip the tests short term. Is there a Jira to track this issue and maybe include the Jira number in a comment here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think it is short term, there is no javadocs in web ui build, so anyway it doesn't make sense to include it while building javadoc
in case of hotfix it doesn't make sense to create a jira imho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok that makes sense- thanks for the extra detail.