Skip to content

manager: Fix a crash #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YuKongA merged 2 commits into from
Jan 7, 2026
+32 −32
Merged

manager: Fix a crash #3140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
101b8ae
manager: Remove feat temporary enable
YuKongA Jan 7, 2026
5b52af6
only update miuix
YuKongA Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manager/app/src/main/java/me/weishu/kernelsu/ui/component/SendLogDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ fun SendLogDialog(
)
SuperArrow(
title = stringResource(id = R.string.save_log),
leftAction = {
startAction = {
Icon(
Icons.Rounded.Save,
contentDescription = null,
Expand All @@ -99,7 +99,7 @@ fun SendLogDialog(
)
SuperArrow(
title = stringResource(id = R.string.send_log),
leftAction = {
startAction = {
Icon(
Icons.Rounded.Share,
contentDescription = null,
Expand Down
4 changes: 2 additions & 2 deletions manager/app/src/main/java/me/weishu/kernelsu/ui/component/SuperEditArrow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ fun SuperEditArrow(
titleColor: BasicComponentColors = BasicComponentDefaults.titleColor(),
defaultValue: Int = -1,
summaryColor: BasicComponentColors = BasicComponentDefaults.summaryColor(),
leftAction: @Composable (() -> Unit)? = null,
startAction: @Composable (() -> Unit)? = null,
insideMargin: PaddingValues = BasicComponentDefaults.InsideMargin,
enabled: Boolean = true,
onValueChange: ((Int) -> Unit)? = null
Expand All @@ -46,7 +46,7 @@ fun SuperEditArrow(
titleColor = titleColor,
summary = dialogTextFieldValue.intValue.toString(),
summaryColor = summaryColor,
leftAction = leftAction,
startAction = startAction,
modifier = modifier,
insideMargin = insideMargin,
onClick = {
Expand Down
4 changes: 2 additions & 2 deletions manager/app/src/main/java/me/weishu/kernelsu/ui/component/UninstallDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,14 @@ fun UninstallDialog(
textAlign = TextAlign.Center,
color = MiuixTheme.colorScheme.onSurface
)
options.forEachIndexed { index, type ->
options.forEach { type ->
SuperArrow(
onClick = {
showConfirmDialog.value = true
runType.value = type
},
title = stringResource(type.title),
leftAction = {
startAction = {
Icon(
imageVector = type.icon,
contentDescription = null,
Expand Down
2 changes: 1 addition & 1 deletion manager/app/src/main/java/me/weishu/kernelsu/ui/component/profile/TemplateConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ fun TemplateConfig(
SuperArrow(
modifier = modifier,
title = stringResource(R.string.app_profile_template_create),
leftAction = {
startAction = {
Icon(
Icons.Rounded.Create,
null,
Expand Down
6 changes: 3 additions & 3 deletions manager/app/src/main/java/me/weishu/kernelsu/ui/screen/AppProfile.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ private fun AppProfileInner(
.padding(bottom = 12.dp),
) {
SuperSwitch(
leftAction = {
startAction = {
Icon(
imageVector = Icons.Rounded.Security,
contentDescription = null,
Expand Down Expand Up @@ -518,7 +518,7 @@ private fun AppProfileInner(
Spacer(Modifier.height(3.dp))
affectedApps.forEach { app ->
BasicComponent(
leftAction = {
startAction = {
AppIconImage(
packageInfo = app.packageInfo,
label = app.label,
Expand Down Expand Up @@ -665,7 +665,7 @@ private fun ProfileBox(
SuperDropdown(
title = stringResource(R.string.profile),
items = list,
leftAction = {
startAction = {
Icon(
Icons.Rounded.AccountCircle,
modifier = Modifier.padding(end = 16.dp),
Expand Down
8 changes: 4 additions & 4 deletions manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Home.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ private fun StatusCard(
BasicComponent(
title = stringResource(R.string.home_not_installed),
summary = stringResource(R.string.home_click_to_install),
leftAction = {
startAction = {
Icon(
Icons.Rounded.ErrorOutline,
stringResource(R.string.home_not_installed),
Expand All @@ -476,7 +476,7 @@ private fun StatusCard(
BasicComponent(
title = stringResource(R.string.home_unsupported),
summary = stringResource(R.string.home_unsupported_reason),
leftAction = {
startAction = {
Icon(
Icons.Rounded.ErrorOutline,
stringResource(R.string.home_unsupported),
Expand Down Expand Up @@ -539,7 +539,7 @@ fun LearnMoreCard() {
BasicComponent(
title = stringResource(R.string.home_learn_kernelsu),
summary = stringResource(R.string.home_click_to_learn_kernelsu),
rightActions = {
endActions = {
Icon(
imageVector = MiuixIcons.Link,
tint = colorScheme.onSurface,
Expand All @@ -564,7 +564,7 @@ fun DonateCard() {
BasicComponent(
title = stringResource(R.string.home_support_title),
summary = stringResource(R.string.home_support_content),
rightActions = {
endActions = {
Icon(
imageVector = MiuixIcons.Link,
tint = colorScheme.onSurface,
Expand Down
4 changes: 2 additions & 2 deletions manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Install.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ fun InstallScreen(navigator: DestinationsNavigator) {
hasCustomSelected = true
partitionSelectionIndex = index
},
leftAction = {
startAction = {
Icon(
MiuixIcons.ConvertFile,
tint = colorScheme.onSurface,
Expand All @@ -273,7 +273,7 @@ fun InstallScreen(navigator: DestinationsNavigator) {
)
},
onClick = onLkmUpload,
leftAction = {
startAction = {
Icon(
MiuixIcons.MoveFile,
tint = colorScheme.onSurface,
Expand Down
28 changes: 14 additions & 14 deletions manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Settings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.rounded.Adb
import androidx.compose.material.icons.rounded.BugReport
import androidx.compose.material.icons.rounded.Colorize
import androidx.compose.material.icons.rounded.ContactPage
import androidx.compose.material.icons.rounded.Delete
import androidx.compose.material.icons.rounded.DeleteForever
import androidx.compose.material.icons.rounded.DeveloperMode
import androidx.compose.material.icons.rounded.EnhancedEncryption
import androidx.compose.material.icons.rounded.Fence
import androidx.compose.material.icons.rounded.FolderDelete
import androidx.compose.material.icons.rounded.Palette
Expand Down Expand Up @@ -146,7 +146,7 @@ fun SettingPager(
SuperSwitch(
title = stringResource(id = R.string.settings_check_update),
summary = stringResource(id = R.string.settings_check_update_summary),
leftAction = {
startAction = {
Icon(
Icons.Rounded.Update,
modifier = Modifier.padding(end = 16.dp),
Expand All @@ -169,7 +169,7 @@ fun SettingPager(
SuperSwitch(
title = stringResource(id = R.string.settings_module_check_update),
summary = stringResource(id = R.string.settings_check_update_summary),
leftAction = {
startAction = {
Icon(
Icons.Rounded.UploadFile,
modifier = Modifier.padding(end = 16.dp),
Expand Down Expand Up @@ -208,7 +208,7 @@ fun SettingPager(
title = stringResource(id = R.string.settings_theme),
summary = stringResource(id = R.string.settings_theme_summary),
items = themeItems,
leftAction = {
startAction = {
Icon(
Icons.Rounded.Palette,
modifier = Modifier.padding(end = 16.dp),
Expand Down Expand Up @@ -257,9 +257,9 @@ fun SettingPager(
title = stringResource(id = R.string.settings_key_color),
summary = stringResource(id = R.string.settings_key_color_summary),
items = colorItems,
leftAction = {
startAction = {
Icon(
Icons.Rounded.Palette,
Icons.Rounded.Colorize,
modifier = Modifier.padding(end = 16.dp),
contentDescription = stringResource(id = R.string.settings_key_color),
tint = colorScheme.onBackground
Expand All @@ -284,7 +284,7 @@ fun SettingPager(
SuperArrow(
title = profileTemplate,
summary = stringResource(id = R.string.settings_profile_template_summary),
leftAction = {
startAction = {
Icon(
Icons.Rounded.Fence,
modifier = Modifier.padding(end = 16.dp),
Expand Down Expand Up @@ -335,7 +335,7 @@ fun SettingPager(
title = stringResource(id = R.string.settings_disable_su),
summary = suSummary,
items = modeItems,
leftAction = {
startAction = {
Icon(
Icons.Rounded.RemoveModerator,
modifier = Modifier.padding(end = 16.dp),
Expand Down Expand Up @@ -395,7 +395,7 @@ fun SettingPager(
title = stringResource(id = R.string.settings_disable_kernel_umount),
summary = umountSummary,
items = modeItems,
leftAction = {
startAction = {
Icon(
Icons.Rounded.RemoveCircle,
modifier = Modifier.padding(end = 16.dp),
Expand Down Expand Up @@ -443,7 +443,7 @@ fun SettingPager(
SuperSwitch(
title = stringResource(id = R.string.settings_umount_modules_default),
summary = stringResource(id = R.string.settings_umount_modules_default_summary),
leftAction = {
startAction = {
Icon(
Icons.Rounded.FolderDelete,
modifier = Modifier.padding(end = 16.dp),
Expand All @@ -465,7 +465,7 @@ fun SettingPager(
SuperSwitch(
title = stringResource(id = R.string.enable_web_debugging),
summary = stringResource(id = R.string.enable_web_debugging_summary),
leftAction = {
startAction = {
Icon(
Icons.Rounded.DeveloperMode,
modifier = Modifier.padding(end = 16.dp),
Expand Down Expand Up @@ -493,7 +493,7 @@ fun SettingPager(
val uninstall = stringResource(id = R.string.settings_uninstall)
SuperArrow(
title = uninstall,
leftAction = {
startAction = {
Icon(
Icons.Rounded.Delete,
modifier = Modifier.padding(end = 16.dp),
Expand All @@ -517,7 +517,7 @@ fun SettingPager(
) {
SuperArrow(
title = stringResource(id = R.string.send_log),
leftAction = {
startAction = {
Icon(
Icons.Rounded.BugReport,
modifier = Modifier.padding(end = 16.dp),
Expand All @@ -533,7 +533,7 @@ fun SettingPager(
val about = stringResource(id = R.string.about)
SuperArrow(
title = about,
leftAction = {
startAction = {
Icon(
Icons.Rounded.ContactPage,
modifier = Modifier.padding(end = 16.dp),
Expand Down
2 changes: 1 addition & 1 deletion manager/app/src/main/java/me/weishu/kernelsu/ui/screen/SuperUser.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ private fun SimpleAppItem(
BasicComponent(
title = app.label,
summary = app.packageName,
leftAction = {
startAction = {
AppIconImage(
packageInfo = app.packageInfo,
label = app.label,
Expand Down
2 changes: 1 addition & 1 deletion manager/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ndk = "29.0.14206865"
libsu = "6.0.0"
apksign = "1.4"
cmaker = "1.2"
miuix = "0.8.0-rc01"
miuix = "0.8.0-rc04"
haze = "1.7.1"
capsule = "2.1.2"

Expand Down