manager: Fix a crash #3140
Merged
manager: Fix a crash #3140
+32
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the temporary enable feature mode for su compatibility and kernel umount settings, simplifying the UI by converting these from three-state dropdowns (Default/Temporarily enable/Permanently enable) to simple on/off switches. The PR also updates the miuix library dependency to a newer release candidate version.
- Converted su compatibility and kernel umount controls from dropdowns to switches
- Removed unused string resources for mode selection across all locale files
- Updated miuix library from 0.8.0-rc01 to 0.8.0-rc04
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| manager/gradle/libs.versions.toml | Updated miuix dependency version from 0.8.0-rc01 to 0.8.0-rc04 |
| manager/app/src/main/res/values/strings.xml | Removed unused mode selection strings (default, temp enable, always enable) |
| manager/app/src/main/res/values-zh-rCN/strings.xml | Removed Chinese translations of unused mode selection strings |
| manager/app/src/main/res/values-vi/strings.xml | Removed Vietnamese translations of unused mode selection strings |
| manager/app/src/main/res/values-uk/strings.xml | Removed Ukrainian translations of unused mode selection strings |
| manager/app/src/main/res/values-th/strings.xml | Removed Thai translations of unused mode selection strings |
| manager/app/src/main/res/values-ru/strings.xml | Removed Russian translations of unused mode selection strings |
| manager/app/src/main/res/values-pl/strings.xml | Removed Polish translations of unused mode selection strings |
| manager/app/src/main/res/values-nl/strings.xml | Removed Dutch translations of unused mode selection strings |
| manager/app/src/main/res/values-ko/strings.xml | Removed Korean translations of unused mode selection strings |
| manager/app/src/main/res/values-ja/strings.xml | Removed Japanese translations of unused mode selection strings |
| manager/app/src/main/res/values-in/strings.xml | Removed Indonesian translations of unused mode selection strings |
| manager/app/src/main/res/values-hr/strings.xml | Removed Croatian translations of unused mode selection strings |
| manager/app/src/main/res/values-fr/strings.xml | Removed French translations of unused mode selection strings |
| manager/app/src/main/res/values-da/strings.xml | Removed Danish translations of unused mode selection strings |
| manager/app/src/main/res/values-bg/strings.xml | Removed Bulgarian translations of unused mode selection strings |
| manager/app/src/main/res/values-ar/strings.xml | Removed Arabic translations of unused mode selection strings (not shown in diff) |
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Settings.kt | Refactored su compat and kernel umount from SuperDropdown to SuperSwitch components, removed complex mode logic, cleaned up imports, reorganized UI element order, and changed key color icon from Palette to Colorize |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f668320 to
0340ae4
Compare
0340ae4 to
101b8ae
Compare
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Jan 7, 2026
* Click the SearchBox when scrolling the Superuser list.
YunZiA
pushed a commit
to YunZiA/KernelSU
that referenced
this pull request
Jan 7, 2026
* Click the SearchBox when scrolling the Superuser list.
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Jan 10, 2026
* Click the SearchBox when scrolling the Superuser list.
PhuScam
pushed a commit
to PhuScam/KernelSU
that referenced
this pull request
Jan 11, 2026
* Click the SearchBox when scrolling the Superuser list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.