Skip to content

Fixes an issue where a user had to click items in a dropdown menu twice in order to trigger an action #15813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codyrancher merged 1 commit into from
Oct 30, 2025
Merged

Fixes an issue where a user had to click items in a dropdown menu twice in order to trigger an action #15813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/rancher-components/src/components/RcDropdown/RcDropdownItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const handleClick = (e: MouseEvent) => {
@click.stop="handleClick"
@keydown.enter.space="handleActivate"
@keydown.up.down.prevent.stop="handleKeydown"
@mousedown.prevent="() => {/*We use this to prevent clicks from triggering the @focusin below. When we scroll on a click it prevents the action from occurring on the first click.*/}"
Copy link
Member Author

@codyrancher codyrancher Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a better way to leave a comment right next to the @focusin I'd be happy to switch.

@focusin="scrollIntoView"
>
<slot name="before">
Expand Down
Loading