Fixes an issue where a user had to click items in a dropdown menu twice in order to trigger an action #15813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce in order to trigger an action Fixes rancher#15520
codyrancher
commented
Oct 30, 2025
| @click.stop="handleClick" | ||
| @keydown.enter.space="handleActivate" | ||
| @keydown.up.down.prevent.stop="handleKeydown" | ||
| @mousedown.prevent="() => {/*We use this to prevent clicks from triggering the @focusin below. When we scroll on a click it prevents the action from occurring on the first click.*/}" |
Member
Author
There was a problem hiding this comment.
If there's a better way to leave a comment right next to the @focusin I'd be happy to switch.
rak-phillip
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15520
Technical notes summary
We would scroll the menu item into view when the menu item received focus. This in turn would prevent the action from getting triggered. We now prevent the focusin event from occurring the user clicks. This allows the focus event to still fire during keyboard navigation.
Areas or cases that should be tested
Anywhere that there's a dropdown menu which has a scrollbar.
Areas which could experience regressions
Keyboard navigation in the dropdown menu.
Screenshot/Video
The cluster page example isn't as obvious because I only had one event but you can tell it's working since the action menu closes on click.
action-menu-click.mp4
Checklist
Admin,Standard UserandUser Base