Skip to content

Removed description from cluster type #15768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eva-vashkevich merged 1 commit into from
Oct 28, 2025
Merged

Removed description from cluster type #15768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions shell/edit/provisioning.cattle.io.cluster/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,17 +389,16 @@ export default {
}

const subtype = {
id: ext.id,
label: ext.label || getters['i18n/t'](`cluster.provider.${ ext.id }`),
description: ext.description,
Copy link
Member

@richard-cox richard-cox Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eva-vashkevich doesn't this affect all extension provided providers and not just hosted?

Copy link
Member Author

@eva-vashkevich eva-vashkevich Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richard-cox it does. I thought we don't want to show descriptions here for consistency? I can make it hosted-specific

Copy link
Member

@richard-cox richard-cox Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this should be hosted specific, and hopefully at some point reverted. What was the underlying reason that descriptions can't be added to hosted providers?

id: ext.id,
label: ext.label || getters['i18n/t'](`cluster.provider.${ ext.id }`),
icon,
iconClass,
group: ext.group || _RKE2,
disabled: ext.disabled || false,
link: ext.link,
tag: ext.tag,
component: ext.component,
hidden: ext.hidden,
group: ext.group || _RKE2,
disabled: ext.disabled || false,
link: ext.link,
tag: ext.tag,
component: ext.component,
hidden: ext.hidden,
};

out.push(subtype);
Expand Down
Loading