Skip to content

Conversation

@eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Oct 28, 2025

Summary

Fixes #15391

Removed cluster type description from cluster creation for Hosted clusters, as discussed in today's demo

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Cluster Management -> Clusters -> Create
Check that cards do not show description for Hosted clusters

Areas which could experience regressions

None

Screenshot/Video

Screenshot 2025-10-28 at 1 19 50 PM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit 406d5e0 into rancher:master Oct 28, 2025
77 of 89 checks passed
@eva-vashkevich eva-vashkevich deleted the iss15391-remove-description branch October 28, 2025 22:31
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 29, 2025
const subtype = {
id: ext.id,
label: ext.label || getters['i18n/t'](`cluster.provider.${ ext.id }`),
description: ext.description,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eva-vashkevich doesn't this affect all extension provided providers and not just hosted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richard-cox it does. I thought we don't want to show descriptions here for consistency? I can make it hosted-specific

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this should be hosted specific, and hopefully at some point reverted. What was the underlying reason that descriptions can't be added to hosted providers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide replacement for kontainerdriver (kev1) existence for displaying (kev2) Hosted Providers

3 participants