Skip to content

Focus namespace filter input after clearing filters #15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rak-phillip merged 3 commits into from
Nov 3, 2025
Merged

Focus namespace filter input after clearing filters #15738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a3b043
Focus namespace filter input after clearing filters
rak-phillip Oct 24, 2025
59075bb
Update namespace filter focus ring color
rak-phillip Oct 31, 2025
7d07b56
Add aria label to filter clear button
rak-phillip Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shell/assets/translations/en-us.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4634,6 +4634,7 @@ namespaceFilter:
button:
clear: Remove applied namespace filters
clearFilter: Clear namespace options filter
removeNamespace: 'Remove {name} from filter'

namespaceList:
selectLabel: Namespace
Expand Down
14 changes: 13 additions & 1 deletion shell/components/nav/NamespaceFilter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,9 +673,16 @@ export default {
},

removeOption(ns, event) {
this.selectOption(ns);
event.preventDefault();
event.stopPropagation();

this.selectOption(ns);

if (event.type !== 'keydown' || this.value.length !== 0) {
return;
}

this.$refs.namespaceFilterInput.focus();
},

defaultOption() {
Expand Down Expand Up @@ -782,6 +789,7 @@ export default {
ghost
class="ns-chip-button"
:data-testid="`namespaces-values-close-${j}`"
:aria-label="t('namespaceFilter.removeNamespace', { name: ns.label })"
@click="removeOption(ns, $event)"
@keydown.enter.space.stop="removeOption(ns, $event)"
@mousedown="handleValueMouseDown(ns, $event)"
Expand Down Expand Up @@ -951,6 +959,10 @@ export default {
display: inline-block;
border-radius: var(--border-radius);

&:focus, &.focused {
@include focus-outline;
}

.ns-glass {
top: 0;
bottom: 0;
Expand Down