Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 24, 2025

Summary

This focuses the namespace filter dropdown when all of the filters are cleared.

Fixes #14383

Occurred changes and/or fixed issues

Technical notes summary

⚠️ Known Issues

The namespace filters dropdown is very inconsistent with how it renders chips. For example, making selections and then immediately clearing them can cause "n items selected" to be the only chip rendered:

image

Navigating into a page that renders namespace filters will render all of the filters, without condensing them:

image

Areas or cases that should be tested

Clearing the final namespace filter via keyboard should focus the input. Clearing the final namespace filter via mouse should open the input (same as existing behavior).

Clearing a namespace filter when other filters exist should behave the same as before.

Areas which could experience regressions

We need to stress the namespace filter component to ensure that the change in functionality hasn't produced side-effects.

Screenshot/Video

2025-10-24.15-14-10.mp4

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments:

  • maybe a nitpick, but can we get the actual blue outline when we do: this.$refs.namespaceFilterInput.focus(); ?

  • let's add an aria-label to that clear namespace filter box/pill/gray thingy (the screen reader does tell anything about that action)

@rak-phillip rak-phillip requested a review from aalves08 October 31, 2025 23:56
@rak-phillip
Copy link
Member Author

@aalves08 ready for another review

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit ffd4e01 into rancher:master Nov 3, 2025
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y: Namespace filter does not gain focus after chips removed

2 participants