Show alternative small scale home page clusters list

[richard-cox]

Summary

Fixes #15570

Occurred changes and/or fixed issues

• if the total cluster count exceeds 100(?) show alt list that's populated with latest 50(?) clusters
• alt list does local pagination

Technical notes summary

• this is a temporary step until the 2.14 based changes from SSP: Integrate SSP with cluster side bar and home page cluster list #14980 are resolved

Areas or cases that should be tested

vai off

• home page normal cluster list is displayed
• changing sort / search does not result in API request

vai on - cluster count is over threshold of 10

• create at least 10 custom / imported clusters (do not need to connect to real clusters)
• apply the following value to /v3/settings/ui-performance,

{"inactivity":{"enabled":false,"threshold":900},"incrementalLoading":{"enabled":false,"threshold":1500},"manualRefresh":{"enabled":false,"threshold":1500},"disableWebsocketNotification":true,"garbageCollection":{"enabled":false,"enabledInterval":true,"interval":300,"enabledOnNavigate":true,"ageThreshold":120,"countThreshold":500},"forceNsFilterV2":{"enabled":false},"advancedWorker":{"enabled":false},"kubeAPI":{"warningHeader":{"separator":"299 - ","notificationBlockList":["299 - unknown field"]}},"serverPagination":{"useDefaultStores":true,"resourceChangesDebounceMs":4000,"features":{ "homePageCluster": { "version":       1, "enabled":       true, "configuration": { "threshold": 10, "results": 8, "pagesPerRow": 5 }}}}}

• home page alt table shown - Showing x of y message visible, age column visible
• changing sort / search does not result in API request

vai on - cluster count is below threshold of 100

• Update ui-performance setting with

{"inactivity":{"enabled":false,"threshold":900},"incrementalLoading":{"enabled":false,"threshold":1500},"manualRefresh":{"enabled":false,"threshold":1500},"disableWebsocketNotification":true,"garbageCollection":{"enabled":false,"enabledInterval":true,"interval":300,"enabledOnNavigate":true,"ageThreshold":120,"countThreshold":500},"forceNsFilterV2":{"enabled":false},"advancedWorker":{"enabled":false},"kubeAPI":{"warningHeader":{"separator":"299 - ","notificationBlockList":["299 - unknown field"]}},"serverPagination":{"useDefaultStores":true,"resourceChangesDebounceMs":4000,"features":{ "homePageCluster": { "version":       1, "enabled":       true, "configuration": { "threshold": 100, "results": 8, "pagesPerRow": 5 }}}}}

• home page normal cluster list is displayed - Showing x message visible, age column not visible
• changing sort / search does not result in API request

Areas which could experience regressions

no others outside of above tests

Previous Versions

1

2

3

Checklist

• The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
• The PR has a Milestone
• The PR template has been filled out
• The PR has been self reviewed
• The PR has a reviewer assigned
• The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
• The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
• The PR has been reviewed in terms of Accessibility

[aalves08]

@richard-cox didn't look at the code yet but gave it a test using your test cases as base. Here are the findings (all of this was tested in a Rancher system provisioned today - image is probably 12h old or around that time - v2.13-2e0b008dace3cc7ba6de6b74cd91f95275ac52bb-head):

• Created 12 custom clusters

• "Normal" settings (didn't change any setting, vai is on by default when rancher is provisioned:

Seems to be fine though, I would say. Sorting doesn't trigger any XHR requests

• vai on, cluster threshold below 10:

met the conditions:

• alt table shown - Showing x of y message visible, age column visible
• changing sort / search does not result in API request

So I would say, looks fine

• vai on, cluster threshold below 100:

I don't see any "Showing x message visible". Sorting does not trigger any XHR requests

• Vai off:

• no age col
• no XHR requests with sorting

Overall
There's something weird with that message part... I haven't yet looked at with a standard user, but I was logged in as a base user when I ran your branch for the first time (vai on, no setting change) and the cluster list did not appear and it had an error on the console...

Could you define more clearly what is test 1, 2 and 3 on the test cases of your PR body so that I can compare better with the screenshots? not only that but the test cases are all text next to one another, so it's kinda confusing to check where one test case stops and another starts.

Also, how do I reset my settings to a "default"/"normal" value so that I could test this again?

[richard-cox]

There's something weird with that message part... I haven't yet looked at with a standard user, but I was logged in as a base user when I ran your branch for the first time (vai on, no setting change) and the cluster list did not appear and it had an error on the console...

I've fixed this and it now matches the old behaviour (no list is shown). It's a bit of an edge case, as soon they gain access to a project / cluster then the cluster list will show as usual.

Could you define more clearly what is test 1, 2 and 3 on the test cases of your PR body so that I can compare better with the screenshots? not only that but the test cases are all text next to one another, so it's kinda confusing to check where one test case stops and another starts.

Done. It looks like your screenshots show this as working.

Also, how do I reset my settings to a "default"/"normal" value so that I could test this again?

The default is just an empty string

[aalves08]

As per our chat and the testing I've done, LGTM. Works as expected for standard and base users

[richard-cox]

/backport v2.12.3 release-2.12

[rancher-ui-project-bot]

Not creating port PR, there was an error running git am -3:

Applying: generic changes from https://github.com/rancher/dashboard/pull/14492/files
Applying: VERY WIP - move out watch event stuff into own file - improve typing - start resolving core unwatch & unwatchIncompatible of side nav cluster watches (not going to store) being seen as incompatible with find cluster action that does go into store
Applying: very wip, vaguely working
Using index info to reconstruct a base tree...
M	shell/components/ResourceDetail/index.vue
Falling back to patching base and 3-way merge...
Auto-merging shell/components/ResourceDetail/index.vue
CONFLICT (content): Merge conflict in shell/components/ResourceDetail/index.vue
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0003 very wip, vaguely working