Skip to content

Commit 60ca9e6

Browse files
authored
Merge pull request #15571 from richard-cox/pagination-home-page-alt-list
Show alternative small scale home page clusters list
2 parents b6765b1 + a1d2fef commit 60ca9e6

File tree

13 files changed

+397
-36
lines changed

13 files changed

+397
-36
lines changed

cypress/e2e/tests/pages/global-settings/settings-p2.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
} from '@/cypress/e2e/blueprints/global_settings/settings-data';
1010

1111
// If there's more than one cluster the currentCluster used in links can be different to `local`
12-
const settingsClusterId = 'local';
12+
const settingsClusterId = '_';
1313
const settingsPage = new SettingsPagePo(settingsClusterId);
1414
const homePage = new HomePagePo();
1515
const accountPage = new AccountPagePo();

cypress/e2e/tests/pages/global-settings/settings.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { settings } from '@/cypress/e2e/blueprints/global_settings/settings-data
99
import UserMenuPo from '@/cypress/e2e/po/side-bars/user-menu.po';
1010

1111
// If there's more than one cluster the currentCluster used in links can be different to `local`
12-
const settingsClusterId = 'local';
12+
const settingsClusterId = '_';
1313
const settingsPage = new SettingsPagePo(settingsClusterId);
1414
const accountPage = new AccountPagePo();
1515
const createKeyPage = new CreateKeyPagePo();

cypress/e2e/tests/pages/users-and-auth/azuread.spec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@ import HomePagePo from '@/cypress/e2e/po/pages/home.po';
22
import AzureadPo from '@/cypress/e2e/po/edit/auth/azuread.po';
33
import { AuthProvider, AuthProviderPo } from '@/cypress/e2e/po/pages/users-and-auth/authProvider.po';
44

5-
const authProviderPo = new AuthProviderPo('local');
6-
const azureadPo = new AzureadPo('local');
5+
const authClusterId = '_';
6+
const authProviderPo = new AuthProviderPo(authClusterId);
7+
const azureadPo = new AzureadPo(authClusterId);
78

89
const tenantId = '564b6f53-ebf4-43c3-8077-44c56a44990a';
910
const applicationId = '18cca356-170e-4bd9-a4a4-2e349855f96b';

cypress/e2e/tests/pages/users-and-auth/cognito.spec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@ import HomePagePo from '@/cypress/e2e/po/pages/home.po';
22
import AmazonCognitoPo from '@/cypress/e2e/po/edit/auth/cognito.po';
33
import { AuthProvider, AuthProviderPo } from '@/cypress/e2e/po/pages/users-and-auth/authProvider.po';
44

5-
const authProviderPo = new AuthProviderPo('local');
6-
const cognitoPo = new AmazonCognitoPo('local');
5+
const authClusterId = '_';
6+
const authProviderPo = new AuthProviderPo(authClusterId);
7+
const cognitoPo = new AmazonCognitoPo(authClusterId);
78

89
const clientId = 'test-client-id';
910
const clientSecret = 'test-client-secret';

cypress/e2e/tests/pages/users-and-auth/githubapp.spec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@ import HomePagePo from '@/cypress/e2e/po/pages/home.po';
22
import GithubAppPo from '@/cypress/e2e/po/edit/auth/githubapp.po';
33
import { AuthProvider, AuthProviderPo } from '@/cypress/e2e/po/pages/users-and-auth/authProvider.po';
44

5-
const authProviderPo = new AuthProviderPo('local');
6-
const githubAppPo = new GithubAppPo('local');
5+
const authClusterId = '_';
6+
const authProviderPo = new AuthProviderPo(authClusterId);
7+
const githubAppPo = new GithubAppPo(authClusterId);
78

89
const clientId = 'test-client-id';
910
const clientSecret = 'test-client-secret';

cypress/e2e/tests/priority/no-vai-setup.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { FeatureFlagsPagePo } from '@/cypress/e2e/po/pages/global-settings/featu
44

55
// Vai ('ui-sql-cache') is now on by default. This sets up the `noVai` test suite by disabling it
66

7-
const featureFlagsPage = new FeatureFlagsPagePo('local');
7+
const featureFlagsPage = new FeatureFlagsPagePo('_');
88

99
describe('Disable Vai', { testIsolation: 'off', tags: ['@noVai', '@adminUser'] }, () => {
1010
before(() => {

shell/assets/styles/base/_typography.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ H1 {
1515
}
1616

1717
H2 {
18-
font-size: 21px;
18+
font-size: $font-size-h2;
1919
}
2020

2121
H3 {

shell/assets/translations/en-us.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3824,6 +3824,11 @@ landing:
38243824
homepage: Homepage
38253825
clusters:
38263826
title: Clusters
3827+
tooMany:
3828+
showAll: Show all clusters (may increase load time)
3829+
showSome: Show some clusters (may improve load time)
3830+
showingAll: Showing {total} clusters.
3831+
showingSome: Showing {rows} of {total} recently created clusters.
38273832
provider: Provider
38283833
distro: Distro
38293834
kubernetesVersion: Kubernetes Version

shell/components/SortableTable/index.vue

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,7 +1090,7 @@ export default {
10901090
<div
10911091
v-if="showHeaderRow"
10921092
class="fixed-header-actions"
1093-
:class="{button: !!$slots['header-button'], 'advanced-filtering': hasAdvancedFiltering}"
1093+
:class="{button: !!$slots['header-button'], 'with-sub-header': !!$slots['sub-header-row'], 'advanced-filtering': hasAdvancedFiltering}"
10941094
>
10951095
<div
10961096
:class="bulkActionsClass"
@@ -1296,6 +1296,12 @@ export default {
12961296
<slot name="header-button" />
12971297
</div>
12981298
</div>
1299+
<div
1300+
v-if="!!$slots['sub-header-row']"
1301+
class="sub-header-row"
1302+
>
1303+
<slot name="sub-header-row" />
1304+
</div>
12991305
</div>
13001306
<table
13011307
ref="table"
@@ -2047,8 +2053,17 @@ export default {
20472053
grid-template-columns: [bulk] auto [middle] min-content [search] minmax(min-content, 350px);
20482054
}
20492055
2056+
$header-padding: 20px;
2057+
.sub-header-row {
2058+
padding: 0 0 $header-padding / 2 0;
2059+
}
2060+
20502061
.fixed-header-actions {
2051-
padding: 0 0 20px 0;
2062+
padding: 0 0 $header-padding 0;
2063+
&.with-sub-header {
2064+
padding: 0 0 $header-padding / 4 0;
2065+
}
2066+
20522067
width: 100%;
20532068
z-index: z-index('fixedTableHeader');
20542069
background: transparent;

0 commit comments

Comments
 (0)