Skip to content

Ensure we don't clear list pages when saving a resource from one #15341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richard-cox merged 2 commits into from
Oct 15, 2025
Merged

Ensure we don't clear list pages when saving a resource from one #15341

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
652817f
Ensure on resource save we don't clear the list cache
richard-cox Sep 5, 2025
bdeb202
Wire in invalidatePageCache to find used in conflict handling
richard-cox Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion shell/plugins/dashboard-store/resource-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,7 +1261,15 @@ export default class Resource {

// Steve sometimes returns Table responses instead of the resource you just saved.. ignore
if ( res && res.kind !== 'Table') {
await this.$dispatch('load', { data: res, existing: (forNew ? this : undefined ) });
// Will loading this resource invalidate the resources in the cache that represent a page (resource is not from page)
// By default we set this to no, it won't pollute the cache. Most likely either
// 1. The resource came from a list already (loaded resource is already in the page that is in the cache)
// 2. UI is not on a page with a list (cache doesn't represent a list)
const invalidatePageCache = opt.invalidatePageCache || false;

await this.$dispatch('load', {
data: res, existing: (forNew ? this : undefined ), invalidatePageCache
});
}
} catch (e) {
if ( this.type && this.id && e?._status === 409) {
Expand Down
Loading