Kgao/federal learning #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
requested changes
Oct 6, 2023
Collaborator
kbattocchi
left a comment
There was a problem hiding this comment.
Mostly looks good, I've suggested a few minor changes to the code. You also need to fix the linting and documentation building CI failures. I didn't review the .rst file yet, since I'll wait until the docs are generated and look at the resulting HTML
Signed-off-by: Keith Battocchi <[email protected]> Signed-off-by: kgao <[email protected]>
Signed-off-by: kgao <[email protected]>
Signed-off-by: kgao <[email protected]>
Signed-off-by: kgao <[email protected]>
Signed-off-by: kgao <[email protected]>
Signed-off-by: kgao <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]> Signed-off-by: kgao <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: kgao <[email protected]>
Signed-off-by: kgao <[email protected]>
Signed-off-by: kgao <[email protected]>
06f6f7b to
6c7e485
Compare
Signed-off-by: kgao <[email protected]>
kbattocchi
requested changes
Oct 18, 2023
Collaborator
kbattocchi
left a comment
There was a problem hiding this comment.
Please clean up the documentation, removing all of the generic content and mainly focusing on the actual classes that perform the work in our library. Explaining that this can be used with Spark is helpful, but should not go into a full intro to Spark (and one benefit of how we've implemented this functionality is that it could also be used with any other distributed computing platform).
Also, please merge the latest changes from main into your branch.
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
* enable nans in W Signed-off-by: Fabio Vera <[email protected]> * linting Signed-off-by: Fabio Vera <[email protected]> * add tests for ests that handle missing in W Signed-off-by: Fabio Vera <[email protected]> * allow missing in X for some ortholearner subclasses Signed-off-by: Fabio Vera <[email protected]> * refactor keyword arg to be bool only, add more tests Signed-off-by: Fabio Vera <[email protected]> * linting Signed-off-by: Fabio Vera <[email protected]> * enable missing for metalearners and orf, fix dowhywrapped discretetreat dmlorf Signed-off-by: Fabio Vera <[email protected]> * update arg name to allow_missing, add docstrings Signed-off-by: Fabio Vera <[email protected]> * add warning when missing values detected Signed-off-by: Fabio Vera <[email protected]> * dummy commit Signed-off-by: Fabio Vera <[email protected]> * dummy commit revert Signed-off-by: Fabio Vera <[email protected]> --------- Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Added Implementation of ray-based distributed parallelization to crossfit. --------- Signed-off-by: Vishal Verma <[email protected]> Signed-off-by: Keith Battocchi <[email protected]> Co-authored-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
kbattocchi
approved these changes
Oct 31, 2023
Collaborator
kbattocchi
left a comment
There was a problem hiding this comment.
Now looks good, will merge once all checks pass.
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Signed-off-by: Keith Battocchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR, please review the documents first.