add arg to allow missing values in W and sometimes X #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e07c5c2 to
ef790e5
Compare
kbattocchi
requested changes
Jul 14, 2023
Collaborator
kbattocchi
left a comment
There was a problem hiding this comment.
Looks good, but please add at least one test exercising this functionality.
90f6fff to
00dd506
Compare
|
Greetings! Per the office hours call - may we let the user opt in to nan's for X in the non parametric DML, the doubly robust learner, S learner, T learner and X learner? All of these models potentially allow for a CATE model able to handle nan's. |
Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Fabio Vera <[email protected]>
9812ef4 to
e34e85f
Compare
…at dmlorf Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Fabio Vera <[email protected]>
kbattocchi
approved these changes
Aug 21, 2023
Collaborator
kbattocchi
left a comment
There was a problem hiding this comment.
These updated changes look good to me.
Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Fabio Vera <[email protected]>
Signed-off-by: Fabio Vera <[email protected]>
kbattocchi
pushed a commit
that referenced
this pull request
Oct 31, 2023
* enable nans in W Signed-off-by: Fabio Vera <[email protected]> * linting Signed-off-by: Fabio Vera <[email protected]> * add tests for ests that handle missing in W Signed-off-by: Fabio Vera <[email protected]> * allow missing in X for some ortholearner subclasses Signed-off-by: Fabio Vera <[email protected]> * refactor keyword arg to be bool only, add more tests Signed-off-by: Fabio Vera <[email protected]> * linting Signed-off-by: Fabio Vera <[email protected]> * enable missing for metalearners and orf, fix dowhywrapped discretetreat dmlorf Signed-off-by: Fabio Vera <[email protected]> * update arg name to allow_missing, add docstrings Signed-off-by: Fabio Vera <[email protected]> * add warning when missing values detected Signed-off-by: Fabio Vera <[email protected]> * dummy commit Signed-off-by: Fabio Vera <[email protected]> * dummy commit revert Signed-off-by: Fabio Vera <[email protected]> --------- Signed-off-by: Fabio Vera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
_OrthoLearner and subclasses
Metalearners
OrthoForest models