Skip to content

[code-infra] Polish VS Code DX #44865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliviertassinari wants to merge 4 commits into
base: master
Choose a base branch
from
+30 −29
Open

[code-infra] Polish VS Code DX #44865

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0003f18
[code-infra] Add Sync recommanded extensions
oliviertassinari Dec 27, 2024
fcff795
[code-infra] Polish VS Code DX
oliviertassinari Dec 27, 2024
ee267e8
prettier
oliviertassinari Dec 27, 2024
94b225a
Update .vscode/settings.json
oliviertassinari Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,9 @@
# top-most EditorConfig file
root = true

[*.md]
trim_trailing_whitespace = false

[*.js]
trim_trailing_whitespace = true

# Unix-style newlines with a newline ending every file
[*]
trim_trailing_whitespace = true
indent_style = space
indent_size = 2
end_of_line = lf
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
.idea
# IntelliJ IDEA module file
*.iml
.vscode/*
!.vscode/launch.json
!.vscode/extensions.json
*.log
*.tsbuildinfo
/.eslintcache
Expand Down
21 changes: 16 additions & 5 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
{
"recommendations": [
"editorconfig.editorconfig",
"dbaeumer.vscode-eslint",
"davidanson.vscode-markdownlint",
"esbenp.prettier-vscode",
"yoavbls.pretty-ts-errors"
// Formating
Copy link
Member

@aarongarciah aarongarciah Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a .json file, should we remove comments?

Copy link
Member Author

@oliviertassinari oliviertassinari Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS Code supports JSONC. Proof https://code.visualstudio.com/docs/languages/json#_json-with-comments

"esbenp.prettier-vscode", // Prettier
"editorconfig.editorconfig", // EditorConfig

// Highlighting
"bradlc.vscode-tailwindcss", // Tailwind CSS
"unifiedjs.vscode-mdx", // MDX
"shardulm94.trailing-spaces", // Trailing spaces
"styled-components.vscode-styled-components", // styled()

// Lint
"dbaeumer.vscode-eslint", // ESLint
"yoavbls.pretty-ts-errors", // TypeScript
"stylelint.vscode-stylelint", // Stylelint
"davidanson.vscode-markdownlint", // markdownlint
"chrischinchilla.vale-vscode" // Vale
]
}
15 changes: 0 additions & 15 deletions .vscode/launch.json
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"editor.defaultFormatter": "esbenp.prettier-vscode",
"files.trimTrailingWhitespace": true,

// Root workspace only
"typescript.tsdk": "node_modules/typescript/lib",
"typescript.surveys.enabled": false,
"grammarly.selectors": [
{
"language": "markdown",
"scheme": "file"
}
]
}
Loading