[code-infra] Polish VS Code DX #44865
Open
+30
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2024
Netlify deploy previewhttps://deploy-preview-44865--material-ui.netlify.app/ Bundle size report |
| "davidanson.vscode-markdownlint", | ||
| "esbenp.prettier-vscode", | ||
| "yoavbls.pretty-ts-errors" | ||
| // Formating |
Member
There was a problem hiding this comment.
This is a .json file, should we remove comments?
Member
Author
There was a problem hiding this comment.
VS Code supports JSONC. Proof https://code.visualstudio.com/docs/languages/json#_json-with-comments
oliviertassinari
commented
Jan 3, 2025
Signed-off-by: Olivier Tassinari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this was due for a refresh.
.vscode/settings.jsonAs I understand it, a baseline version of this is supposed to be stored on git (then people can add their settings to further customize it). Proof:
I have tried to only have the least opinionated settings.
.editorconfigNow that we have
.mdxand.tsxfiles, this is due for a refresh. We also started to stop relying ontrim_trailing_whitespacefor markdown line break (but instead use\). So we can apply this everywhere. See #34762.I also got annoyed with the UX on https://mui.com/toolpad/
.gitignoreRemove .vscode, per VS Code codebase, they don't do this.
.vscode/extensions.jsonI suspect that those mui/base-ui#1151 got introduced because the right VS Code extension wasn't installed.
.vscode/launch.jsonThis is for
I'm not aware anyone uses it. We would need to clean up it.
Same PR open in all the repositories ⬇️