Correctly document the default for dns.override_local_dns #2640
Conversation
Pull Request Revisions
✅ AI review completed for r1 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
There was a problem hiding this comment.
Thanks for bringing this up, but I think we should change the default value in case the option dns.override_local_dns is missing in the configuration instead.
Sure but that would be another breaking change. |
Good point, depends on who you ask. Changing the default in the config is a breaking change for users that either started using Headscale with 0.26.0 or upgraded and migrated the config. Changing the fallback value in the code is a breaking change for users that upgraded but did not migrate the configuration while upgrading to 0.26.0. @kradalby what is your take? |
Let's go with your suggestion. Thx for bringing it up! |
|
@dotlambda could you please rebase and force-push? Github CI seems to be broken again :( |
Pull request was closed
Since v0.26.0 [^1], Headscale overrides clients' local DNS settings by default and therefore requires the configuration to provide a list of nameservers to pass to them [^2][^3]. This commit exposes the dns.override_local_dns setting using the default from upstream and validates that the required nameservers are provided if it's enabled. [^1]: https://github.com/juanfont/headscale/releases/tag/v0.26.0 [^2]: juanfont/headscale#2438 [^3]: juanfont/headscale#2640 provide clients access to the local system's network in any way.
See #2438 (comment).