-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Restore support for "Override local DNS" #2438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Revisions
HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
Tailscale allows to override the local DNS settings of a node via
"Override local DNS" [1]. Restore this flag with the same config setting
name `dns.override_local_dns` but disable it by default to align it with
Tailscale's default behaviour.
Tested with Tailscale 1.80.2 and systemd-resolved on Debian 12.
With `dns.override_local_dns: false`:
```
Link 12 (tailscale0)
Current Scopes: DNS
Protocols: -DefaultRoute -LLMNR -mDNS -DNSOverTLS DNSSEC=no/unsupported
DNS Servers: 100.100.100.100
DNS Domain: tn.example.com ~0.e.1.a.c.5.1.1.a.7.d.f.ip6.arpa [snip]
```
With `dns.override_local_dns: true`:
```
Link 12 (tailscale0)
Current Scopes: DNS
Protocols: +DefaultRoute -LLMNR -mDNS -DNSOverTLS DNSSEC=no/unsupported
DNS Servers: 100.100.100.100
DNS Domain: tn.example.com ~.
```
[1] https://tailscale.com/kb/1054/dns#override-local-dns
Fixes: juanfont#2256
|
|
||
| viper.SetDefault("dns.magic_dns", true) | ||
| viper.SetDefault("dns.base_domain", "") | ||
| viper.SetDefault("dns.override_local_dns", true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think https://github.com/juanfont/headscale/pull/2438/files#r2046953908 is correct. I also just ran into this and needed to turn local dns override off.
|
This being on by default now immediately breaks old configs that didn't specify the option and don't have any global nameserver set. Was that intentional? |
This was enabled (and enforced) for 0.23.x, 0.24.x and 0.25.x and an upgrade without adjusting the configuration will still have this option enabled. But using "Override local DNS" without specifying global nameservers is an error which is now checked for. |
|
To add my 2 cents, I think this has also broken the config for me, on Linux I couldn't resolve the hostnames anymore that are set up using |
For some reason this was enabled by default in 0.26.0 even though it breaks existing configurations. ¯\_(ツ)_/¯ juanfont/headscale#2438
Tailscale allows to override the local DNS settings of a node via "Override local DNS" [1]. Restore this flag with the same config setting name
dns.override_local_dnsbut disable it by default to align it with Tailscale's default behaviour.Tested with Tailscale 1.80.2 and systemd-resolved on Debian 12.
With
dns.override_local_dns: false:With
dns.override_local_dns: true:[1] https://tailscale.com/kb/1054/dns#override-local-dns
Fixes: #2256