refactor(font): migrate to scripting system powered by Rust/subsecond #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a9148a to
5e23c45
Compare
a8212c6 to
e180ae3
Compare
lynzrand
approved these changes
Jun 16, 2025
| mod math; | ||
| mod shape; | ||
|
|
||
| use monoxide_script::{FontParamSettings, ast::FontContext}; |
Collaborator
There was a problem hiding this comment.
IMHO FontParamSettings can be left in the font crate instead of going into monoxide_script, since it's actually per-font?
Collaborator
Author
There was a problem hiding this comment.
This is pre-existing; probably it'd be better to leave it to another PR. Also, I haven't cleaned up the flocking JS code yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21.
Blocking on:
--argsand handle merging in@serverand@clientDioxusLabs/dioxus#4212