-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix --args and handle merging in @server and @client
#4212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ealmloff Many thanks for the patch! I've tried it locally on my project and it works pretty well without issues. Is there any remaining blocker preventing this from being merged? |
|
We added support for multi-platform serve: dx serve \
@client --package dashboard \
@server --package serverHow does this PR interact the multi-target builds? It seems like we can only pass args to the final target? |
Currently, it passes args to both binaries if you serve desktop + fullstack. It looks like dx serve -- shared args @client -- client args @server -- server args It might require parsing more stuff manually without clap. We also currently only allow separate build args for the client and server, not serve args like |
--args and handle merging in @server and @client
|
I couldn't find a good way to get the last argument working with subcommand, so I switched back to a string args. You can now do
|
You can pass args to the executable(s) opened by dx after a trailing
--just likecargo run:Fixes #4122
Fixes #4250