Skip to content

Conversation

tonynajjar and others added 3 commits December 11, 2025 12:11
…ts (ros-navigation#5485)

* Publish criticsStats

Signed-off-by: Tony Najjar <[email protected]>

* linting

Signed-off-by: Tony Najjar <[email protected]>

* change header to stamp

Signed-off-by: Tony Najjar <[email protected]>

* make unique_pointer

Signed-off-by: Tony Najjar <[email protected]>

* typo

Signed-off-by: Tony Najjar <[email protected]>

* Add readme

Signed-off-by: Tony Najjar <[email protected]>

* add to readme

Signed-off-by: Tony Najjar <[email protected]>

* fixes

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>
…5636)

* [mppi] fix division by zero

leading to cost values being NaNs, which then propagate through all the critics and results in NaN control_sequence. These NaNs were removed by the hard applyControlSequenceConstraints(), but replaced with ax_max & wz_max. These lead to high steering at the start of a run

Signed-off-by: Adi Vardi <[email protected]>

* [mppi] clean ackermann constraints

Signed-off-by: Adi Vardi <[email protected]>

* fix long line

Signed-off-by: Adi Vardi <[email protected]>

---------

Signed-off-by: Adi Vardi <[email protected]>
@jonipol jonipol requested a review from tanelikor December 11, 2025 10:18
@jonipol jonipol self-assigned this Dec 11, 2025
Copy link
Member

@tanelikor tanelikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonipol jonipol merged commit a9d5bd8 into humble_main_karelics Dec 11, 2025
@jonipol jonipol deleted the mppi_critic_monitoring_cherry branch December 11, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants