Skip to content

fix: dx bundle progress output off-by-one in log lines #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkelleyrtp merged 4 commits into from
May 7, 2025
Merged

fix: dx bundle progress output off-by-one in log lines #4014

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bb5c8f
fix: dx bundle progress output off-by-one in log lines
chrivers Apr 19, 2025
28d4409
fix: Emit the name of the last compiled unit (feedback from @DogeDark)
chrivers Apr 22, 2025
332c69c
fix: Log "Compiled" instead of "Compiling", since the log refers to c…
chrivers Apr 22, 2025
f3f9bae
Merge remote-tracking branch 'origin/main' into chrivers/dx-bundle-pr…
jkelleyrtp May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/cli/src/build/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,15 +223,19 @@ impl Builder {
krate,
..
} => {
tracing::info!("Compiling [{current:>3}/{total}]: {krate}");
tracing::info!("Compiled [{current:>3}/{total}]: {krate}");
}
BuildStage::RunningBindgen => tracing::info!("Running wasm-bindgen..."),
BuildStage::CopyingAssets {
current,
total,
path,
} => {
tracing::info!("Copying asset ({current}/{total}): {}", path.display());
tracing::info!(
"Copying asset ({}/{total}): {}",
current + 1,
path.display()
);
}
BuildStage::Bundling => tracing::info!("Bundling app..."),
_ => {}
Expand Down
10 changes: 2 additions & 8 deletions packages/cli/src/build/request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,8 @@ impl BuildRequest {
Message::CompilerMessage(msg) => self.status_build_diagnostic(msg),
Message::CompilerArtifact(artifact) => {
units_compiled += 1;
match artifact.executable {
Some(executable) => output_location = Some(executable.into()),
None => self.status_build_progress(
units_compiled,
crate_count,
artifact.target.name,
),
}
self.status_build_progress(units_compiled, crate_count, artifact.target.name);
output_location = artifact.executable.map(Into::into);
}
Message::BuildFinished(finished) => {
if !finished.success {
Expand Down
Loading