-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: dx bundle progress output off-by-one in log lines #4014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dx bundle progress output off-by-one in log lines #4014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the crate count isn't off-by-one, but rather we don't emit the last log. If you want to fix that, I think we need to change:
dioxus/packages/cli/src/build/request.rs
Lines 201 to 208 in a946842
| match artifact.executable { | |
| Some(executable) => output_location = Some(executable.into()), | |
| None => self.status_build_progress( | |
| units_compiled, | |
| crate_count, | |
| artifact.target.name, | |
| ), | |
| } |
To be something along the lines of:
unites_compiled += 1;
self.status_build_progress(units_compiled, crate_count, artifact.target.name);
output_location = artifact.executable.map(|e| e.into());The rest looks good!
…ompleted units, not in-progress ones
|
@DogeDark thanks for the hint - fixed, and tested. Indeed, one more unit turns up now. Also, I changed the text from This makes the log output much less confusing. Previously, if something was taking a long time to compile, the wrong crate was getting the blame! |
|
Wow, that's a heavy CI job.. is that normal? @DogeDark I guess the CI needs to be poked? :) |
* fix: dx bundle progress output off-by-one in log lines * fix: Emit the name of the last compiled unit (feedback from @DogeDark) * fix: Log "Compiled" instead of "Compiling", since the log refers to completed units, not in-progress ones --------- Co-authored-by: Jonathan Kelley <[email protected]>
* fix: dx bundle progress output off-by-one in log lines * fix: Emit the name of the last compiled unit (feedback from @DogeDark) * fix: Log "Compiled" instead of "Compiling", since the log refers to completed units, not in-progress ones --------- Co-authored-by: Jonathan Kelley <[email protected]>
Before:
After: