Update micro-editor/terminal and support terminal emulator in platforms
#3714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syscall is replaced with IoctlSetWinsize in this version to fix a build error that occurs with Solaris.
Support terminal emulation on platforms below: - Solaris - NetBSD: Supported in creack/pty since v1.1.12 - OpenBSD with GOOS != amd64 - Other architectures are supported now in creack/pty
Copy build constraints in actions_other.go to terminal_unsupported.go, to avoid maintaining separate build constraints that are similar with terminal_supported.go.
c830ae9 to
2bb3c9a
Compare
JoeKar
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terminal emulator in Micro was only tested on OpenIndiana (Illumos distribution) a bit. Additional changes are also done in other commits.
Fixes #3585