Skip to content

Updating SaveCmd to use saveBufToFile instead #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmaluka merged 2 commits into from
Mar 12, 2025
Merged

Updating SaveCmd to use saveBufToFile instead #3689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9f1220
Updating SaveCmd to use saveBufToFile instead
Neko-Box-Coder Mar 11, 2025
9003243
Removing the use of SetName() for file buffers
Neko-Box-Coder Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/action/actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,6 @@ func (h *BufPane) saveBufToFile(filename string, action string, callback func())
if err != nil {
InfoBar.Error(err)
} else {
h.Buf.SetName(filename)
InfoBar.Message("Saved " + filename)
if callback != nil {
callback()
Expand All @@ -1067,7 +1066,6 @@ func (h *BufPane) saveBufToFile(filename string, action string, callback func())
InfoBar.Error(err)
}
} else {
h.Buf.SetName(filename)
InfoBar.Message("Saved " + filename)
if callback != nil {
callback()
Expand Down
5 changes: 1 addition & 4 deletions internal/action/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,10 +907,7 @@ func (h *BufPane) SaveCmd(args []string) {
if len(args) == 0 {
h.Save()
} else {
err := h.Buf.SaveAs(args[0])
if err != nil {
InfoBar.Error(err)
}
h.saveBufToFile(args[0], "SaveAs", nil)
Copy link
Collaborator

@dmaluka dmaluka Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing action="SaveAs" will in the end cause executing onSaveAs lua callback, which is supposed to be executed by the SaveAs action, not by a command?

Copy link
Contributor Author

@Neko-Box-Coder Neko-Box-Coder Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the if block few lines above which calls Save() will also cause a lua callback. I don't mind either way to have an action or not.

Copy link
Collaborator

@dmaluka dmaluka Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the if block few lines above which calls Save() will also cause a lua callback. I don't mind either way to have an action or not.

Good point. Ok, maybe some users are already relying on that, so let's stay consistent with this inconsistency...

}
}

Expand Down