Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 18, 2024

Description

Global setup's reject error stack is not rewritten, so this test case is flawed. I found this when testing vitejs/vite#18983.

Also now debugging this issue too #7130.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bb42397
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6784bc18784d0f0008795558
😎 Deploy Preview https://deploy-preview-7096--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa changed the title test: skip broken source map test test: skip broken source map test (test Vite PR 18983) Dec 25, 2024
@hi-ogawa hi-ogawa changed the title test: skip broken source map test (test Vite PR 18983) test: debug Vite PR 18983 Jan 8, 2025
@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Mar 7, 2025

Closing by #7621

@hi-ogawa hi-ogawa closed this Mar 7, 2025
@hi-ogawa hi-ogawa deleted the test-vite-18983 branch March 7, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant