Skip to content

Conversation

@vdovhanych
Copy link
Owner

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@vdovhanych vdovhanych force-pushed the group-self branch 6 times, most recently from 5858b41 to 1ff358a Compare August 18, 2025 13:59
@vdovhanych
Copy link
Owner Author

This should ideally resolve juanfont#2618 but i'm not opening the PR to the upstream repository just yet.

@vdovhanych vdovhanych changed the title WIP feat: test adding the autogroup:self feature WIP - feat: adding the autogroup:self feature Aug 19, 2025

// Filter returns the current network filter rules and matches.
func (s *State) Filter() ([]tailcfg.FilterRule, []matcher.Match) {
return s.polMan.Filter()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Filter and use FilterForNode


type PolicyManager interface {
// Filter returns the current filter rules for the entire tailnet and the associated matchers.
Filter() ([]tailcfg.FilterRule, []matcher.Match)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@vbrandl
Copy link

vbrandl commented Sep 25, 2025

Is there anything concrete, a first time contributor could do to get this ready to be merged? Or would this make the coordination simply more complicated?

@vdovhanych
Copy link
Owner Author

It's not yet in a state where it can be merged, so I only have it here in my forked pull request. I will work on it over this weekend and hopefully get it to the point where it will work as expected. After that, the maintainers can consider merging it, but it's not yet finished.

@almereyda
Copy link

Just to check what's the difference: This PR targets [the main branch in the vdovhanych fork of Headscale], which is currently 56 commits behind upstream.

Will there be a way for this contribution to move back up to juanfont/headscale as well?

@vdovhanych vdovhanych force-pushed the group-self branch 2 times, most recently from 1c6b321 to 5bb838d Compare September 30, 2025 08:42
@vdovhanych
Copy link
Owner Author

Closing this fork pr and opening the pull request in the upstream repository. It seems to function as expected now and further development will be there.

@vdovhanych vdovhanych closed this Sep 30, 2025
@almereyda
Copy link

For anyone who wants to follow:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants