-
Notifications
You must be signed in to change notification settings - Fork 0
WIP - feat: adding the autogroup:self feature #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vdovhanych
commented
Aug 6, 2025
- have read the CONTRIBUTING.md file
- raised a GitHub issue or discussed it on the projects chat beforehand
- added unit tests
- added integration tests
- updated documentation if needed
- updated CHANGELOG.md
5858b41 to
1ff358a
Compare
|
This should ideally resolve juanfont#2618 but i'm not opening the PR to the upstream repository just yet. |
|
|
||
| // Filter returns the current network filter rules and matches. | ||
| func (s *State) Filter() ([]tailcfg.FilterRule, []matcher.Match) { | ||
| return s.polMan.Filter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Filter and use FilterForNode
|
|
||
| type PolicyManager interface { | ||
| // Filter returns the current filter rules for the entire tailnet and the associated matchers. | ||
| Filter() ([]tailcfg.FilterRule, []matcher.Match) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
|
Is there anything concrete, a first time contributor could do to get this ready to be merged? Or would this make the coordination simply more complicated? |
|
It's not yet in a state where it can be merged, so I only have it here in my forked pull request. I will work on it over this weekend and hopefully get it to the point where it will work as expected. After that, the maintainers can consider merging it, but it's not yet finished. |
|
Just to check what's the difference: This PR targets [the main branch in the vdovhanych fork of Headscale], which is currently 56 commits behind upstream. Will there be a way for this contribution to move back up to juanfont/headscale as well? |
1c6b321 to
5bb838d
Compare
b459cb3 to
3331cf5
Compare
|
Closing this fork pr and opening the pull request in the upstream repository. It seems to function as expected now and further development will be there. |
|
For anyone who wants to follow: |