Skip to content

Bug Fix: Update uplift.pyx with isinstance(v, Numbers.number)) #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeongyoonlee merged 2 commits into from
Sep 17, 2025
Merged

Bug Fix: Update uplift.pyx with isinstance(v, Numbers.number)) #849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84a05a1
Update uplift.pyx with isinstance(v, (int, float, np.number)):
00helloworld Jul 23, 2025
e059dd1
Update uplift.pyx with isinstance(v, numbers.Number):
00helloworld Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions causalml/inference/tree/uplift.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ from joblib import Parallel, delayed
from packaging import version
from sklearn.model_selection import train_test_split
from sklearn.utils import check_X_y, check_array, check_random_state
import numbers

if version.parse(sklearn.__version__) >= version.parse('0.22.0'):
from sklearn.utils._testing import ignore_warnings
Expand Down Expand Up @@ -2264,7 +2265,7 @@ class UpliftTreeClassifier:
else:
v = observations[tree.col]
branch = None
if isinstance(v, int) or isinstance(v, float):
if isinstance(v, numbers.Number):
if v >= tree.value:
branch = tree.trueBranch
else:
Expand Down Expand Up @@ -2311,7 +2312,7 @@ class UpliftTreeClassifier:
return dict(result)
else:
branch = None
if isinstance(v, int) or isinstance(v, float):
if isinstance(v, numbers.Number):
if v >= tree.value:
branch = tree.trueBranch
else:
Expand Down