Skip to content

Conversation

@mdo
Copy link
Member

@mdo mdo commented Aug 29, 2025

Moves most of the Sass variables into the component files. For forms and buttons, I'm going to create some centralized files most likely. Same for the overlays, like modal and offcanvas. I'll do that separately.

In case you're wondering why we'd do this, it makes customization via Sass very convenient.

// Example format for new variable default overrides
@use "theme" with (
  $text-color: white,
  $background-color: black,
);

@mdo mdo added this to v6.0.0 Aug 29, 2025
@mdo mdo requested a review from a team as a code owner August 29, 2025 03:52
@github-project-automation github-project-automation bot moved this to Inbox in v6.0.0 Aug 29, 2025
@mdo mdo merged commit 485c598 into v6-dev Aug 29, 2025
7 checks passed
@mdo mdo deleted the v6-move-vars branch August 29, 2025 04:27
mdo added a commit that referenced this pull request Sep 10, 2025
* Co-locate Sass variables in most files

* another

* fix

* Don't bring tables into reboot, temp remove some sass vars so we don't need the co-dependency

* Move vars

* bundlewatch

* scssdocs

* Fix scssdocs
mdo added a commit that referenced this pull request Sep 16, 2025
* Co-locate Sass variables in most files

* another

* fix

* Don't bring tables into reboot, temp remove some sass vars so we don't need the co-dependency

* Move vars

* bundlewatch

* scssdocs

* Fix scssdocs
mdo added a commit that referenced this pull request Sep 21, 2025
* Co-locate Sass variables in most files

* another

* fix

* Don't bring tables into reboot, temp remove some sass vars so we don't need the co-dependency

* Move vars

* bundlewatch

* scssdocs

* Fix scssdocs
mdo added a commit that referenced this pull request Oct 10, 2025
* Co-locate Sass variables in most files

* another

* fix

* Don't bring tables into reboot, temp remove some sass vars so we don't need the co-dependency

* Move vars

* bundlewatch

* scssdocs

* Fix scssdocs
mdo added a commit that referenced this pull request Nov 14, 2025
* Co-locate Sass variables in most files

* another

* fix

* Don't bring tables into reboot, temp remove some sass vars so we don't need the co-dependency

* Move vars

* bundlewatch

* scssdocs

* Fix scssdocs
mdo added a commit that referenced this pull request Jan 9, 2026
* Co-locate Sass variables in most files

* another

* fix

* Don't bring tables into reboot, temp remove some sass vars so we don't need the co-dependency

* Move vars

* bundlewatch

* scssdocs

* Fix scssdocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants