Skip to content

osdlib: document why empty catch blocks are intentional #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kellemar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

osdlib: document why empty catch blocks are intentional #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions tslib/services/osdlib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ class OSD
doc.osdStartLoading();
}
}
catch (exception) {}
catch (exception)
{
// Silently ignore - OSD methods may throw in cross-origin iframe contexts
}
}

startSaving()
Expand All @@ -37,7 +40,10 @@ class OSD
doc.osdStartSaving();
}
}
catch (exception) {}
catch (exception)
{
// Silently ignore - OSD methods may throw in cross-origin iframe contexts
}
}

stopLoading()
Expand All @@ -50,7 +56,10 @@ class OSD
doc.osdStopLoading();
}
}
catch (exception) {}
catch (exception)
{
// Silently ignore - OSD methods may throw in cross-origin iframe contexts
}
}

stopSaving()
Expand All @@ -63,7 +72,10 @@ class OSD
doc.osdStopSaving();
}
}
catch (exception) {}
catch (exception)
{
// Silently ignore - OSD methods may throw in cross-origin iframe contexts
}
}

// Constructor function
Expand Down