Address recent security reports #195
Merged
+334
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESultanik
requested changes
Jan 9, 2026
Collaborator
ESultanik
left a comment
There was a problem hiding this comment.
Looks good in general, but I noticed one potential issue that might cause us to miss detections of malicious imports.
fickling/fickle.py
Outdated
| def unsafe_imports(self) -> Iterator[ast.Import | ast.ImportFrom]: | ||
| for node in self.properties.imports: | ||
| if node.module in ( | ||
| if node.module and node.module.split(".")[0] in ( |
Collaborator
There was a problem hiding this comment.
Let's say you have a module that does something like this:
foo/bar.py
import code # or any other unsafe module
⠇and that module doesn't set __all__ to explicitly set exports. That allows the pickle to import foo.bar.code and it will work!
Therefore, I think we need to match against all of the components of the module path:
if any(component in EXISTING_LIST_OF_DANGEROUS_MODULES for component in node.module.split(".")):
Collaborator
Author
There was a problem hiding this comment.
Implemented with 595d7bb, thanks! Matching subpackages like os could be too broad, I'll keep an eye on new issues after the release.
ESultanik
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes GHSA-wfq2-52f7-7qvj, GHSA-q5qq-mvfm-j35x, GHSA-p523-jq9w-64x9, GHSA-5hvc-6wx8-mvv4, GHSA-h4rm-mm56-xf63.
The changes are mostly additions to the list of unsafe imports, with the exception of GHSA-h4rm-mm56-xf63 that required emitting AST nodes for builtins imports, and GHSA-q5qq-mvfm-j35x for which we now extract top-level package names instead of comparing the full import name to the blocklist of unsafe imports.