Skip to content

Conversation

@CanerKaraca23
Copy link
Contributor

@CanerKaraca23 CanerKaraca23 commented Dec 22, 2025

Fixed zip and zip-extensions errors.

Some changes made by AI, so please review, edits welcomed.

Copilot AI review requested due to automatic review settings December 22, 2025 21:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependencies in the ksud project, primarily focusing on updating which (7→8), zip (3→7), and zip-extensions (0.8→0.13). The changes also modernize string formatting throughout the codebase by converting from old-style format strings to inline format strings.

  • Updated key dependencies: which, zip, and zip-extensions
  • Modernized string formatting using inline format syntax
  • Fixed import path for zip_extract_file_to_memory to accommodate zip-extensions API changes

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
userspace/ksud/Cargo.toml Updated dependency versions for which, zip, and zip-extensions
userspace/ksud/Cargo.lock Reflected dependency updates with new version checksums and transitive dependencies
userspace/ksud/src/su.rs Modernized format strings for GID error messages
userspace/ksud/src/sepolicy.rs Modernized format strings for policy parsing and rule application errors
userspace/ksud/src/module_config.rs Modernized format strings for config validation and magic number errors
userspace/ksud/src/module.rs Updated zip-extensions import path and modernized module ID validation error format
userspace/ksud/src/metamodule.rs Modernized format strings for script execution errors
userspace/ksud/src/feature.rs Modernized format string for unknown feature error
userspace/ksud/src/boot_patch.rs Modernized format strings and improved error message formatting with .display() for paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aviraxp aviraxp merged commit c27263e into tiann:main Dec 24, 2025
18 checks passed
@CanerKaraca23 CanerKaraca23 deleted the ksud branch December 24, 2025 07:12
rsuntk pushed a commit to rsuntk/KernelSU that referenced this pull request Dec 24, 2025
Fixed `zip` and `zip-extensions` errors.

Signed-off-by: rsuntk <[email protected]>
u9521 pushed a commit to u9521/KernelSU that referenced this pull request Jan 5, 2026
Fixed `zip` and `zip-extensions` errors.
u9521 pushed a commit to u9521/KernelSU that referenced this pull request Jan 5, 2026
Fixed `zip` and `zip-extensions` errors.
u9521 pushed a commit to u9521/KernelSU that referenced this pull request Jan 8, 2026
Fixed `zip` and `zip-extensions` errors.
u9521 pushed a commit to u9521/KernelSU that referenced this pull request Jan 13, 2026
Fixed `zip` and `zip-extensions` errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants