-
-
Notifications
You must be signed in to change notification settings - Fork 3k
add module config, migrate managedFeatures #2965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a module configuration system to KernelSU, migrating the managed features mechanism from module.prop to a dedicated binary config storage format. The new system provides persistent and temporary configuration capabilities for modules, with command-line tools for management.
- Introduces binary config file format with persist/temp support for per-module configuration storage
- Migrates managed features from module.prop declarations to config system entries (manage.=true)
- Adds CLI commands for modules to manage their own configuration via
KSU_MODULEenvironment variable - Implements feature management authorization based on module ownership
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| userspace/ksud/src/module_config.rs | New module implementing binary config file I/O, validation, and config management APIs |
| userspace/ksud/src/module.rs | Updates module loading to extract KSU_MODULE env var, read managed features from config, and clear configs on uninstall |
| userspace/ksud/src/main.rs | Registers the new module_config module |
| userspace/ksud/src/init_event.rs | Adds temp config cleanup during post-fs-data initialization |
| userspace/ksud/src/feature.rs | Updates feature system to check module ownership via config system and skip managed features during init |
| userspace/ksud/src/defs.rs | Defines config directory paths and file name constants |
| userspace/ksud/src/cli.rs | Adds module config subcommands (get, set, list, delete, clear) with persist/temp options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: YuKongA <[email protected]>
Co-authored-by: YuKongA <[email protected]> Signed-off-by: u9521 <[email protected]>
Co-authored-by: YuKongA <[email protected]> Signed-off-by: u9521 <[email protected]>
Co-authored-by: YuKongA <[email protected]> Signed-off-by: u9521 <[email protected]>
No description provided.