Skip to content

Conversation

@Ylarod
Copy link
Collaborator

@Ylarod Ylarod commented Nov 20, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a module configuration system to KernelSU, migrating the managed features mechanism from module.prop to a dedicated binary config storage format. The new system provides persistent and temporary configuration capabilities for modules, with command-line tools for management.

  • Introduces binary config file format with persist/temp support for per-module configuration storage
  • Migrates managed features from module.prop declarations to config system entries (manage.=true)
  • Adds CLI commands for modules to manage their own configuration via KSU_MODULE environment variable
  • Implements feature management authorization based on module ownership

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 19 comments.

Show a summary per file
File Description
userspace/ksud/src/module_config.rs New module implementing binary config file I/O, validation, and config management APIs
userspace/ksud/src/module.rs Updates module loading to extract KSU_MODULE env var, read managed features from config, and clear configs on uninstall
userspace/ksud/src/main.rs Registers the new module_config module
userspace/ksud/src/init_event.rs Adds temp config cleanup during post-fs-data initialization
userspace/ksud/src/feature.rs Updates feature system to check module ownership via config system and skip managed features during init
userspace/ksud/src/defs.rs Defines config directory paths and file name constants
userspace/ksud/src/cli.rs Adds module config subcommands (get, set, list, delete, clear) with persist/temp options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ylarod Ylarod merged commit be44ee0 into main Nov 20, 2025
18 checks passed
@Ylarod Ylarod deleted the managed-feature branch November 20, 2025 13:50
KOWX712 pushed a commit to KOWX712/KernelSU that referenced this pull request Nov 20, 2025
u9521 added a commit to u9521/KernelSU that referenced this pull request Jan 4, 2026
u9521 added a commit to u9521/KernelSU that referenced this pull request Jan 5, 2026
u9521 added a commit to u9521/KernelSU that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants