manager: if manager incompatible with current kernel, don't save ksud #2895
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This will cause lots of bug too. |
Contributor
Author
hmmm, maybe i need add a ksud update when user update kernel to solve this problem? i will write a new commit |
Contributor
Author
|
@tiann can you review again? |
tiann
approved these changes
Nov 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors when the KernelSU daemon (ksud) installation occurs, moving it from app startup to after successful direct boot installations, with additional guards for outdated kernels.
- Moved
install()call fromMainActivity.onCreate()toinstallBoot()when direct installation succeeds - Added kernel version check to prevent
install()from running when kernel is outdated - Fixed code style issue (removed unnecessary semicolon)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| manager/app/src/main/java/me/weishu/kernelsu/ui/util/KsuCli.kt | Moved install() call to occur after successful direct boot installation instead of at app startup; removed semicolon from getRootShell() call |
| manager/app/src/main/java/me/weishu/kernelsu/ui/MainActivity.kt | Added kernel version check to prevent install() from running when requireNewKernel() returns true |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aviraxp
approved these changes
Nov 9, 2025
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Nov 10, 2025
…tiann#2895) I think we should'nt install kernelsu's userspace when manager incompatible with current kernel this maybe cause a lot of bug, for example, when user install 2.x kernelsu manager, but not update his kernel to 2.x, ksud will return "kernel version 0", because ksud incompatible with old supercall impl
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 3, 2026
…tiann#2895) I think we should'nt install kernelsu's userspace when manager incompatible with current kernel this maybe cause a lot of bug, for example, when user install 2.x kernelsu manager, but not update his kernel to 2.x, ksud will return "kernel version 0", because ksud incompatible with old supercall impl
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 3, 2026
…tiann#2895) I think we should'nt install kernelsu's userspace when manager incompatible with current kernel this maybe cause a lot of bug, for example, when user install 2.x kernelsu manager, but not update his kernel to 2.x, ksud will return "kernel version 0", because ksud incompatible with old supercall impl
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
…tiann#2895) I think we should'nt install kernelsu's userspace when manager incompatible with current kernel this maybe cause a lot of bug, for example, when user install 2.x kernelsu manager, but not update his kernel to 2.x, ksud will return "kernel version 0", because ksud incompatible with old supercall impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should'nt install kernelsu's userspace when manager incompatible with current kernel
this maybe cause a lot of bug, for example, when user install 2.x kernelsu manager, but not update
his kernel to 2.x, ksud will return "kernel version 0", because ksud incompatible with old supercall impl