Skip to content

kernel: supercall: allow escalation on ioctl interface #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ylarod merged 2 commits into from
Nov 5, 2025
Merged

kernel: supercall: allow escalation on ioctl interface #2862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
837373d
kernel: supercall: allow escalation on ioctl interface
backslashxx Nov 4, 2025
6ca7fbd
addendum as suggested by Ylarod
backslashxx Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions kernel/supercalls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,15 @@ bool always_allow(void)
return true; // No permission check
}

static int do_grant_root(void __user *arg)
bool allowed_for_su(void)
{
// Check if current UID is allowed
bool is_allowed = is_manager() || ksu_is_allow_uid(current_uid().val);
return is_allowed;
}

if (!is_allowed) {
return -EPERM;
}
static int do_grant_root(void __user *arg)
{
// we already check uid above on allowed_for_su()

pr_info("allow root for: %d\n", current_uid().val);
escape_to_root();
Expand Down Expand Up @@ -330,7 +331,7 @@ static int do_set_feature(void __user *arg)

// IOCTL handlers mapping table
static const struct ksu_ioctl_cmd_map ksu_ioctl_handlers[] = {
{ .cmd = KSU_IOCTL_GRANT_ROOT, .name = "GRANT_ROOT", .handler = do_grant_root, .perm_check = manager_or_root },
{ .cmd = KSU_IOCTL_GRANT_ROOT, .name = "GRANT_ROOT", .handler = do_grant_root, .perm_check = allowed_for_su },
{ .cmd = KSU_IOCTL_GET_INFO, .name = "GET_INFO", .handler = do_get_info, .perm_check = always_allow },
{ .cmd = KSU_IOCTL_REPORT_EVENT, .name = "REPORT_EVENT", .handler = do_report_event, .perm_check = only_root },
{ .cmd = KSU_IOCTL_SET_SEPOLICY, .name = "SET_SEPOLICY", .handler = do_set_sepolicy, .perm_check = only_root },
Expand Down