Unmount isolated process which forks from zygote unconditionally #2747

aviraxp · 2025-09-07T13:13:57Z

Rethink about this patch, isolated process which directly forks from zygote is just like normal app, so there is no reason apps won't crash but Isolated process will. Also zygote reopens fd before actually fork, so it should be fine.

This reverts commit 2a1741d.

Rethink about this patch, isolated process which directly forks from zygote is just like normal app, so there is no reason apps won't crash but Isolated process will. Also zygote reopens fd before actually fork, so it should be fine. This reverts commit 2a1741d.

Copilot

Pull Request Overview

This PR reverts a previous change to handle isolated processes differently when unmounting overlayfs. The change rethinks the logic for isolated processes that fork directly from zygote, treating them like normal applications rather than avoiding unmounting operations.

Reverts special handling that prevented unmounting for isolated processes
Refactors function names to clarify their purpose (renaming functions for better clarity)
Ensures isolated processes forked from zygote are properly handled with unconditional unmounting

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

kernel/core_hook.c

…nn/KernelSU#2747) Rethink about this patch, isolated process which directly forks from zygote is just like normal app, so there is no reason apps won't crash but Isolated process will. Also zygote reopens fd before actually fork, so it should be fine. This reverts commit tiann/KernelSU@2a1741d.

-remove some extra spaces from (TG) patch -try_umount -> ksu_try_umount if not CONFIG_KSU_SUSFS_TRY_UMOUNT (ksu_handle_setuid) -7/10/25: selinux/rules: fix merge conflict with previous change (Fix illegal RCU lock usage): __4d633a1 -7/14/25: core_hook: fix merge conflict with previous change (remove redundant get_cred_rcu): __bd03c29 -7/20/25: ksud: fix merge conflict with previous change (guard syscall hook types): __45ad73e -7/20/26: core_hook: fix merge conflict with previous change (support for KernelNoSU): __948975b -7/24/25: core_hook: fix merge conflict with previous change (allow only perms ... and guard kernelnosu perms): __3f4c23a -8/10/25: Kconfig: fix merge conflict with previous change (nest ksun switch manager support) __e0c4613 -9/7/25: core_hook: fix merge conflict with previous change (Unmount isolated process) __'Unmount isolated process which forks from zygote unconditionally (tiann/KernelSU#2747)' -https://gitlab.com/simonpunk/susfs4ksu/-/tree/gki-android14-6.1

- 1. We flag the zygote spawned process TIF_PROC_ROOT_NOT_ALLOWED durint ksu_set_uid() if it is not root allowed - 2. THen we ust check the flag before going into any ksu syscall handlers in sucompat.c, because it is just a check of a bit flag so it is ultra fast for non root allowed process which is bascially and theoretically side channel attacks free - 3. Other processes that are not flagged with TIF_PROC_ROOT_NOT_ALLOWED will just go thru the ksu syscall handlers just the same as before -9/7/25: core_hook: fix merge conflict with previous change (Unmount isolated process) __'Unmount isolated process which forks from zygote unconditionally (tiann/KernelSU#2747)' -https://gitlab.com/simonpunk/susfs4ksu/-/tree/gki-android14-6.1 -sucompat: retain logic (ksu_is_allow_uid)

- In order to reduce the extra patch code and increase the rate of hunk succeed, we do not rename the symbols in KernelSU drvier but instead do it all in kernel/kallsym.c - Make susfs_starts_with() global as it maybe useful in future -9/7/25: core_hook: fix merge conflict with previous change (Unmount isolated process) __'Unmount isolated process which forks from zygote unconditionally (tiann/KernelSU#2747)' -https://gitlab.com/simonpunk/susfs4ksu/-/tree/gki-android14-6.1 -Revert (Ref: 'kernel: implement susfs v1.5.8 KernelSU Next v1.0.8') - __resolves 'undefined symbols': ksu_is_manager_apk, is_manager, track_throne: ____apk_sign, throne_tracker: ksu_is_manager_apk -> is_manager_apk ____manager: ksu_is_manager -> is_manager ____throne_tracker: ksu_track_throne -> track_throne