Duplicated values and sums #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a grouping of records in
get_trend_databy device alongside date, and also adds an instruction for the LLM to keep track of duplicates - this should solve the issue of e.g. duplicated steps, by warning the user that some values are probably duplicates (and excluding them from the results) (subissue #22)Another thing added is sums in
get_trend_data- so far, if the user asked for the sum of some values the LLM would search for records within that timeframe, and the write a script summing them up - which is very inefficient. Instead, a sum field is added to one of the tools and the client is disencouraged from writing scripts for things like summing up values. (subissue #23)