Search values MCP tool #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It should have also solve issue #15, am I right? |
KaliszS
approved these changes
Sep 11, 2025
Collaborator
KaliszS
left a comment
There was a problem hiding this comment.
In the future we want to fine tune docstring in tools comments, ebcause tehre is a lot of redundancy now. But first we have to explore more advanced tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tool used for searching for exact matches of values for the three database options existing in the server (DuckDB, ClickHouse, Elasticsearch).
The tool provides a way to search for text values, while also being able to specify the date range and record type. Since it deals correctly with text values, it solves the issue #7 - you can easily search for specific values, like with the example of sleep types touched upon in #7.
A thing worth considering is improving the docstrings so that the LLM can know what exactly it can look for - now, only 1 example (sleep types) is specified, and there isn't exactly a good documentation for what other values / record types can hold string values.