fix: port upstream changes to use Windows token in LocalAPI #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caddy and Traefik are both Go 1.23 or greater. May not need to pin the version any more.
This was referenced May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tailscale implementation of this functionality has changed somewhat. The update changes the way the Windows access token is retrieved, giving a better approximation of the current process' rights.
This seems to fix issues found in #13, where calling the certificate API causes the remote Tailscale daemon to shut down.
Ultimately this is a very selective port to see if the issues I was experiencing are addressed: there are other, later updates to this area that could also be ported.
Note that this change requires Go 1.23 or above. Traefik and Caddy currently meet this criteria, so this may be OK to adopt.
See tailscale/tailscale#9049