Skip to content

ArgsTable: Add subsections and design cleanup #11216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shilman merged 26 commits into from
Jun 22, 2020
Merged

ArgsTable: Add subsections and design cleanup #11216

shilman merged 26 commits into from
Jun 22, 2020

Conversation

@shilman
Copy link
Member

@shilman shilman commented Jun 17, 2020 •
edited
Loading

Issue: #11211

What I did

  • Added subcategories to arg table
  • Added expand/collapse
  • Updated stories w/ controls

How to test

See updated stories/chromatic

@shilman shilman added this to the 6.0 docs milestone Jun 17, 2020
@domyen domyen self-assigned this Jun 17, 2020
domyen and others added 15 commits June 18, 2020 11:55
@domyen domyen mentioned this pull request Jun 20, 2020
Closed
@shilman shilman marked this pull request as ready for review June 22, 2020 02:17
@shilman
Copy link
Member Author

shilman commented Jun 22, 2020

Self-merging @domyen

@shilman shilman changed the title ArgsTable: Design refresh WIP ArgsTable: Design refresh Jun 22, 2020
@shilman shilman changed the title ArgsTable: Design refresh ArgsTable: Add subsections and design cleanup Jun 22, 2020
@shilman shilman merged commit 2f8d93c into next Jun 22, 2020
@shilman shilman deleted the 11211-argstable-design-refresh branch June 22, 2020 02:21
@shilman shilman mentioned this pull request Jun 22, 2020
Closed
8 tasks
@sami616
Copy link

sami616 commented Jul 11, 2020

Hi @shilman @domyen does this PR allow for sub components to have their own controls? if so is this documented anywhere??

@domyen
Copy link
Member

domyen commented Jul 11, 2020 •
edited
Loading

This PR addresses the design, styling, and behavior of ArgsTable. It doesn't address the underlying mechanics for subcomponents & args as far as I know. @shilman might know more about how it all fits together with the issue you filed a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@domyen domyen

Labels

addon: docs block: props feature request

Projects

None yet

Milestone

6.0 docs

Development

Successfully merging this pull request may close these issues.

4 participants

@shilman @sami616 @domyen