This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Implement 'mouseover' #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adieuadieu
suggested changes
Aug 16, 2017
Collaborator
adieuadieu
left a comment
There was a problem hiding this comment.
Hi @ronanyeah Thank you for raising this PR! I noticed some small typo's. Please have a look 😃
src/chrome/local-runtime.ts
Outdated
| case 'mousedown': | ||
| return this.mousedown(command.selector) | ||
| case 'mouseover': | ||
| return this.mousedown(command.selector) |
Collaborator
There was a problem hiding this comment.
Hm... looks maybe like a typo. Did you mean this.mouseover?
src/chrome/local-runtime.ts
Outdated
| } | ||
|
|
||
| const { scale } = this.chromelessOptions.viewport | ||
| await mousedown(this.client, selector, scale) |
Collaborator
There was a problem hiding this comment.
Same here. Did you mean await mouseover() ?
Author
|
@adieuadieu Oops! Should be fixed now and seems to work still. |
|
Why this PR is closed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5
Seems to work correctly locally but I presume I will need to add tests.