Skip to content

Conversation

@jameslamb
Copy link
Contributor

  • passes make lint
  • adds tests to tests/ (if appropriate)

What does this PR change?

This PR introduces a GitHub Actions workflow for publishing to PyPi. A PyPi secret has been set up in the repo settings, for use with this template.

How does this PR improve prefect-saturn?

This PR automates publishing of the project so users don't have to rely on GitHub to install the package.

@jameslamb jameslamb requested review from dotNomad and jsignell July 20, 2020 21:57
sdist
bdist_wheel
- name: Publish distribution to PyPI
if: startsWith(github.event.ref, 'refs/tags')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably don't need this if you are only doing the action on publish.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooo right!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed this in 1635245

@jameslamb jameslamb requested a review from jsignell July 21, 2020 18:18
Copy link
Contributor

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jameslamb jameslamb merged commit c1b5058 into main Jul 21, 2020
@jameslamb jameslamb deleted the ci/pypi branch July 24, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants