Skip to content

Conversation

@mini-1235
Copy link
Contributor

@mini-1235 mini-1235 commented Nov 19, 2025

Description

Fixes ros2/rviz#513

Is this user-facing behavior change?

Yes, the logs will appear less frequently

Did you use Generative AI?

No

Additional Information

Related to ros-navigation/navigation2#5163, before the initial_pose is set, without this change, the terminal will be flooded with log like:

[rviz2-9] [INFO 1763554575.338340800] [rviz]: Message Filter dropping message: frame 'odom' at time 54.105 for reason 'discarding message because the queue is full' (signalFailure() at /root/nav2_ws/src/geometry2/tf2_ros/include/tf2_ros/message_filter.hpp:771)
[rviz2-9] [INFO 1763554575.400898439] [rviz]: Message Filter dropping message: frame 'rplidar_link' at time 59.502 for reason 'discarding message because the queue is full' (signalFailure() at /root/nav2_ws/src/geometry2/tf2_ros/include/tf2_ros/message_filter.hpp:771)

cc @SteveMacenski

@ahcorde
Copy link
Contributor

ahcorde commented Nov 19, 2025

Pulls: #851
Gist: https://gist.githubusercontent.com/ahcorde/501a14da6a49e80a0175d887d8881c1e/raw/1d9239a216220da92d94d7ba683ef3c12e1f4c80/ros2.repos
BUILD args: --packages-above-and-dependencies tf2_ros
TEST args: --packages-above tf2_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17536

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 00ea530 into ros2:rolling Nov 20, 2025
2 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Nov 20, 2025

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2025

backport kilted jazzy humble

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Nov 20, 2025
Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 00ea530)

# Conflicts:
#	tf2_ros/include/tf2_ros/message_filter.hpp
mergify bot pushed a commit that referenced this pull request Nov 20, 2025
Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 00ea530)

# Conflicts:
#	tf2_ros/include/tf2_ros/message_filter.hpp
mergify bot pushed a commit that referenced this pull request Nov 20, 2025
Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 00ea530)

# Conflicts:
#	tf2_ros/include/tf2_ros/message_filter.hpp
@mini-1235 mini-1235 deleted the patch-1 branch November 21, 2025 12:29
ahcorde added a commit that referenced this pull request Nov 24, 2025
* Prevent log spam from tf2_ros message_filter (#851)

Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 00ea530)
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Nov 24, 2025
* Prevent log spam from tf2_ros message_filter (#851)

Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 00ea530)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Nov 24, 2025
* Prevent log spam from tf2_ros message_filter (#851)

Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 00ea530)
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
idesign0 pushed a commit to idesign0/id_geometry2 that referenced this pull request Dec 17, 2025
…2#854)

* Prevent log spam from tf2_ros message_filter (ros2#851)

Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 00ea530)
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Many signalFailure - Drop message warnings on startup

2 participants