Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 25, 2025

min_height / max_height applied to a pointcloud source in the CM is not anymore relative to base_frame_id but relative to the frame_id of that source when not using use_global_height.
Can be quite critical as impacting which part of a pointcloud are used in the collision monitor/detector.
I believe since: #5586
Draft to get the info out asap but not yet 100% checked. Will need extra sanity checks.


This is an automatic backport of pull request #5794 done by Mergify.

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
(cherry picked from commit 4534ff1)
@mergify
Copy link
Contributor Author

mergify bot commented Dec 25, 2025

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski merged commit 3fc1600 into jazzy Dec 25, 2025
6 of 8 checks passed
@mergify mergify bot deleted the mergify/bp/jazzy/pr-5794 branch December 25, 2025 00:18
@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
nav2_collision_monitor/src/pointcloud.cpp 96.36% <100.00%> (+0.13%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants