-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Removing underlay workspace from Main #5732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Steve Macenski <[email protected]>
|
Rolling sync has started https://discourse.openrobotics.org/t/preparing-for-rolling-sync-2025-12-01/51178, I open this PR to check everything is fine after the sync |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Signed-off-by: mini-1235 <[email protected]>
|
Actually the sync is not finished yet, that's why I am marking as draft. I don't know why the system tests are passing |
Oh, I know why, the docker images is failing since September 30 https://github.com/ros-navigation/nav2_docker/actions/runs/19680004866/job/56371331768 Edit: I was wrong, I think it's because the CI image is only updated once the PR is merged, I can see errors in the nightly CI now |
|
I looked deeper into the nav2_docker image:
As a result,
ps: this also explains why CI in this repo is working fine, but not nav2 docker |
|
Got it - I did see that the rolling job was failing and I nudged the repo to get the builds starting again (github will deactivate github action jobs if the repo isn't active for 90 days; unfortunately that means repos like nav2_docker which are meant to be autonomous occasionally need a bogus commit to make it turn over again). I had it on my list for this week to figure out why that was happening since I kickstarted it again, but it looks like you beat me to it! Why not update the docker image to install QT6 in the preamble so that its always present before anything starts to build / dependencies being pulled in? |
* Removing underlay workspace from Main (ros-navigation#5200) Signed-off-by: Steve Macenski <[email protected]> * Try updating key to avoid building with cache Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: mini-1235 <[email protected]> Co-authored-by: Steve Macenski <[email protected]>
* Removing underlay workspace from Main (ros-navigation#5200) Signed-off-by: Steve Macenski <[email protected]> * Try updating key to avoid building with cache Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: Steve Macenski <[email protected]> Signed-off-by: mini-1235 <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Decwest <[email protected]>
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.